Skip to content

Acceptance Review Loop

Use this playbook after implementation validation is already recorded with wap-flow complete.

Lifecycle terms stay distinct throughout this loop:

  • completed: implementation validation evidence recorded
  • accepted: acceptance gates currently pass
  • finalized: accept finalize wrote the accepted closeout decision
  • closed: a GitHub issue was actually closed
Terminal window
wap-flow accept init --preset <manual|agent|balanced> --profile <local|local_pr|github> [--surface issue|pr|local] [--pr <number>]
wap-flow accept status

accept can be used for both GitHub-backed and local-private authority. issue and local surfaces both work for local-private tasks; issue keeps issue-style findings locally without requiring promotion. pr surfaces and pr lifecycle commands remain GitHub-only.

Terminal window
wap-flow accept manual --by <name> --result pass --evidence "<what was reviewed>"
wap-flow accept check --strict
wap-flow accept finalize

For local-private tasks, this is the normal closeout path. It reaches accepted and finalized state locally without closing a GitHub issue, whether the acceptance session uses surface: local or surface: issue.

Terminal window
wap-flow accept review --agent claude_local
wap-flow accept status
wap-flow accept resolve --finding <id> --evidence "<fix evidence>"
wap-flow accept check --strict
Terminal window
wap-flow accept request-review --agent <id>
wap-flow accept wait-remote --agent <id> --for claim
wap-flow accept wait-remote --agent <id> --for result
wap-flow accept sync --agent <id>
wap-flow accept status

This path is GitHub-backed only.

If findings remain open:

Terminal window
wap-flow accept resolve --finding <id> --evidence "<fix evidence>"
wap-flow accept request-review --agent <id>
  • review_enforcement.closeout remains mandatory blocking.
  • review_enforcement.commit and review_enforcement.push are disabled by default, are valid only for compatible local non-PR profiles, and are true no-ops when disabled.
  • warn is not a supported review-enforcement mode.
  • accept finalize must stay blocked while the current remote request is unclaimed or claimed-pending.
  • accept check --strict and pr reconcile --strict require reviews bound to the current review target commit.
  • Treat repeated remote stalls as sandbox or provider evidence, not as silent success.